prefetch_test.cc: Fix address sanitizer warning#14233
Open
evanj wants to merge 1 commit intofacebook:mainfrom
Open
prefetch_test.cc: Fix address sanitizer warning#14233evanj wants to merge 1 commit intofacebook:mainfrom
evanj wants to merge 1 commit intofacebook:mainfrom
Conversation
evanj
force-pushed
the
evan.jones/prefetch_test-sanitizer
branch
from
d6ee99e to
b71b5cb
Compare
This fixes the following warning from make check. This is triggered
because FSBufferPrefetchUnalignedReads did not clear the callbacks,
and its installe callback can be triggered by other tests.
Add 2 ClearAllCallbacks calls to attempt to avoid these problems.
The callback in TEST_P(PrefetchTest, Basic) did not cause sanitizer
problems, but code inspection shows that I don't think it clears the
callbacks and it probably should.
Fixes:
==1472548==ERROR: AddressSanitizer: stack-use-after-return on address 0x7693d37dc3d0 at pc 0x5603e97a25b9 bp 0x7fffa002dfa0 sp 0x7fffa002df98
READ of size 4 at 0x7693d37dc3d0 thread T0
#0 0x5603e97a25b8 in rocksdb::FSBufferPrefetchTest_FSBufferPrefetchUnalignedReads_Test::TestBody()::$_0::operator()(void*) const /home/bits/rocksdb/file/prefetch_test.cc:3728:51
evanj
force-pushed
the
evan.jones/prefetch_test-sanitizer
branch
from
b71b5cb to
fb03895
Compare
Contributor
Author
|
I just rebased this to attempt to clear what I think was a flaky test failure. I just checked and this still happens with main commit as of right now 2026-01-29. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the following warning from make check. This is triggered because FSBufferPrefetchUnalignedReads did not clear the callbacks, and its installed callback can be triggered by other tests.
Add 2 ClearAllCallbacks calls to attempt to avoid these problems. The callback in TEST_P(PrefetchTest, Basic) did not cause sanitizer problems, but code inspection shows that I don't think it clears the callbacks and it probably should.
Fixes: